Add plan for rebar3 #921
Add plan for rebar3 #921
Conversation
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
| # The `/usr/bin/env` path is hardcoded, so we'll add a symlink if needed. | ||
| if [[ ! -r /usr/bin/env ]]; then | ||
| ln -sv $(pkg_path_for coreutils)/bin/env /usr/bin/env | ||
| _clean_env=true |
There was a problem hiding this comment.
this appears to be unused
There was a problem hiding this comment.
updated so that it's used now
|
this needs a runtime dep for |
| _clean_env=true | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
Possible to remove the one extra newline?
|
When I ran the rebar3 plan and examined [11][default:/hab/pkgs/core/rebar3/3.1.1/20160624160040/bin:0]# head -n 2 rebar3
#!/usr/bin/env escript
%%Given that strictly inside Habitat, we can't guarantee that
|
* Updated Erlang plan to include missing sed dep Signed-off-by: Elliott Davis <[email protected]>
|
good catch on that binary @fnichol - I got it patched up using fix_interpreter. I also got the newline removed. |
|
@thesentinels delegate=elliott-davis I'm delegating merge access to you, please read these instructions for more info! |
|
✌️ @elliott-davis can now approve this pull request |
|
📌 Commit 191022c has been approved by |
Add plan for rebar3 Signed-off-by: Elliott Davis <[email protected]>
|
☀️ Test successful - travis |
Add plan for relx * Note - this is blocked by the PR #921 Signed-off-by: Elliott Davis <[email protected]>
|
Built and uploaded to depot https://app.habitat.sh/#/pkgs/core/rebar3/3.1.1/20160630160805 |
Signed-off-by: Elliott Davis [email protected]