Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plan for jruby support #946

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Add plan for jruby support #946

merged 1 commit into from
Jun 22, 2016

Conversation

elliott-davis
Copy link
Contributor

Signed-off-by: Elliott Davis [email protected]

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer

Add plan for jruby support
b225520 
Signed-off-by: Elliott Davis <[email protected]>
bookshelfdave
bookshelfdave reviewed Jun 21, 2016
View reviewed changes
plans/jruby/plan.sh
pkg_lib_dirs=(lib)

do_build() {
./mvnw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does JRuby ship with maven?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no - but the script does download it. I think ideally there should be a plan for maven.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is! #928

@elliott-davis
Copy link
Contributor Author

okay so I've tried getting this to work with fix_interpreter but as soon as SELF_PATH=$(builtin cd -P -- "$(dirname -- "$0")" >/dev/null && pwd -P) && SELF_PATH=$SELF_PATH/$(basename -- "$0") execs bash dies when the shebang line is #!/hab/pkgs/core/busybox-static/1.24.2/20160612081725/bin/env bash. However, when the shebang line is #!/hab/pkgs/core/bash/1.24.2/20160612081725/bin/bash everything executes as expected. I would like to merge this as is and work on figuring out what is going on with fix_interpreter later.

@bookshelfdave
Copy link
Contributor

seems legit

# /hab/pkgs/core/jruby/9.1.2.0/20160622160900/bin/jruby --version
jruby 9.1.2.0 (2.3.0) 2016-06-22 fffffff Java HotSpot(TM) 64-Bit Server VM 25.92-b14 on 1.8.0_92-b14 +jit [linux-x86_64]

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit b225520 has been approved by metadave

@thesentinels
Copy link
Contributor

⌛ Testing commit b225520 with merge 65caffc...

thesentinels pushed a commit that referenced this pull request Jun 22, 2016
@thesentinels
Add plan for jruby support
65caffc 
Signed-off-by: Elliott Davis <[email protected]>

Pull request: #946
Approved by: metadave
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit b225520 into habitat-sh:master Jun 22, 2016
@bookshelfdave
Copy link
Contributor

package uploaded to the depot as https://app.habitat.sh/#/pkgs/core/jruby/9.1.2.0/20160622160900

@elliott-davis elliott-davis deleted the jruby branch June 22, 2016 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliott-davis @thesentinels @bookshelfdave