Add Standard output and error formatting #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has passed 'Verify' and is ready for review and approval! |
* Creates a new output module, that handles colorizing and pretty output * Adds the output!, outputln!, and output_format! macros, that work like print!, println!, and format!, but use the output module. * Adds the LOGKEY constant, for tracking where messages come from within bldr. * Adds a 'verbose' flag to every command, that adds the file name, line number, and column where the output statement was called. * Moves our errors into a BldrError struct, which tracks the file, line, and column where the error was created. * Adds a bldr_error! macro, which takes the renamed "ErrorKind" enum as an argument, and creates a new BldrError instead. * Prints all errors as if the "verbose" flag was always on - the side effect is that all errors (except those driven by the From trait) include the file name and line number they were created from. * Updates every user-visible print! and println! statement to use output! and outputln! * Updates every occurence of BldrError to use the bldr_error! macro instead
adamhjk
force-pushed
the
output-awesome
branch
from
0abebea to
a8b9db4
Compare
|
|
|
This PR has passed 'Verify' and is ready for review and approval! |
|
|
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Nov 24, 2015
Merged change d5648710-6084-4f8e-9fed-65863eae4a79 From review branch output-awesome into master Signed-off-by: reset <[email protected]>
|
Change: d5648710-6084-4f8e-9fed-65863eae4a79 approved by: @reset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print!, println!, and format!, but use the output module.
bldr.
number, and column where the output statement was called.
and column where the error was created.
an argument, and creates a new BldrError instead.
effect is that all errors (except those driven by the From trait)
include the file name and line number they were created from.
output! and outputln!
instead