Adding check of alive status to haproxy.conf
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation does not remove dead nodes from its config. This causes timeouts if backend nodes go away. It can also lead to config conflicts if new nodes come up with the same IP as stale node entries. This change allows nodes to be removed from haproxy when they are deemed no longer alive by the supervisor. Signed-off-by: Nolan Davidson <[email protected]>
|
By analyzing the blame information on this pull request, we identified @kevindickerson and @adamhjk to be potential reviewers |
|
@thesentinels delegate=nsdavidson I'm delegating merge access to you, please read these instructions for more info! |
|
📌 Commit 8a3424d has been approved by |
thesentinels
added a commit
that referenced
this pull request
Jun 30, 2016
Adding check of `alive` status to haproxy.conf The current implementation does not remove dead nodes from its config. This causes timeouts if backend nodes go away. It can also lead to config conflicts if new nodes come up with the same IP as stale node entries. This change allows nodes to be removed from haproxy when they are deemed no longer alive by the supervisor. Signed-off-by: Nolan Davidson <[email protected]>
|
☀️ Test successful - travis |
|
Built and uploaded to depot https://app.habitat.sh/#/pkgs/core/haproxy/1.6.5/20160630143421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not remove dead nodes from its config. This causes timeouts if
backend nodes go away. It can also lead to config conflicts if new nodes come up with the same IP
as stale node entries.
This change allows nodes to be removed from haproxy when they are deemed no longer alive by the supervisor.
Signed-off-by: Nolan Davidson [email protected]