Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: firebase auth implementation #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: firebase auth implementation #160

wants to merge 1 commit into from
+459 −83

Conversation

AnkushSarkar10
Copy link
Collaborator

@AnkushSarkar10 AnkushSarkar10 commented Feb 6, 2025 •
edited
Loading

all the auth

@AnkushSarkar10 Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AnkushSarkar10 AnkushSarkar10 force-pushed the 02-05-feat_firebase_auth_implementation branch 2 times, most recently from d1efbd6 to ac559e6 Compare February 7, 2025 07:02
owengretzinger
owengretzinger reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@owengretzinger owengretzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use MMKV? And then we should be able to get rid of all the async stuff unless it depends on the server.

If it doesn't get rid of all the async, can we create a hook so that we don't need the loading useStates everywhere?

Also fix type errors

@AnkushSarkar10 AnkushSarkar10 marked this pull request as ready for review February 9, 2025 04:31
@graphite-app graphite-app bot requested a review from owengretzinger February 9, 2025 04:32
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 9, 2025

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (02/09/25)

1 reviewer was added to this PR based on Owen Gretzinger's automation.

@AnkushSarkar10 AnkushSarkar10 force-pushed the 02-05-feat_firebase_auth_implementation branch from ac559e6 to 4483bef Compare February 9, 2025 04:46
@AnkushSarkar10 AnkushSarkar10 force-pushed the 02-05-feat_firebase_auth_implementation branch from 4483bef to cc0d367 Compare February 18, 2025 17:55
owengretzinger
owengretzinger requested changes Feb 27, 2025
View reviewed changes
@owengretzinger Graphite App
Copy link
Collaborator

Also can you change the default pfp to an actual placeholder pfp

@AnkushSarkar10 AnkushSarkar10 force-pushed the 02-05-feat_firebase_auth_implementation branch from cc0d367 to 638cb92 Compare March 1, 2025 21:01
@AnkushSarkar10 Graphite App
Copy link
Collaborator Author

Also can you change the default pfp to an actual placeholder pfp

i like this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owengretzinger owengretzinger Awaiting requested review from owengretzinger owengretzinger is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnkushSarkar10 @owengretzinger