fix: sveltejs#4265 prevent double update when bind to object

hackape · Jul 18, 2023 · 8484d92 · 8484d92
1 parent d2d219f
commit 8484d92
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/svelte/src/compiler/compile/render_dom/wrappers/InlineComponent/index.js b/packages/svelte/src/compiler/compile/render_dom/wrappers/InlineComponent/index.js
@@ -345,8 +345,8 @@ export default class InlineComponentWrapper extends Wrapper {
 				block.maintain_context = true; // TODO put this somewhere more logical
 			}
 			block.chunks.init.push(b`
-				function ${id}(#value) {
-					${callee}(${args});
+				function ${id}(#value, #init_binding) {
+					${callee}(!!#init_binding, ${args});
 				}
 			`);
 			let invalidate_binding = b`
@@ -361,8 +361,10 @@ export default class InlineComponentWrapper extends Wrapper {
 				`;
 			}
 			const body = b`
-				function ${id}(${params}) {
-					${invalidate_binding}
+				function ${id}(#init_binding, ${params}) {
+					if (!#init_binding || ${lhs} !== #value) {
+						${invalidate_binding}
+					}
 				}
 			`;
 			component.partly_hoisted.push(body);

diff --git a/packages/svelte/src/runtime/internal/Component.js b/packages/svelte/src/runtime/internal/Component.js
@@ -24,7 +24,7 @@ export function bind(component, name, callback) {
 	const index = component.$$.props[name];
 	if (index !== undefined) {
 		component.$$.bound[index] = callback;
-		callback(component.$$.ctx[index]);
+		callback(component.$$.ctx[index], /** init_binding */ true);
 	}
 }