Check that workshops have a LICENSE file in root #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredkhan
requested changes
Feb 17, 2018
| @@ -54,6 +54,7 @@ struct WorkshopsController { | |||
| var warnings: [String] = [] | |||
| if workshop.title == "Sample Workshop" { warnings.append("Title has not been set") } | |||
| if workshop.contributors.isEmpty { warnings.append("Contributors have not been listed") } | |||
| if !workshop.hasLicense { warnings.append("Lisence missing: The root of the workshop repo should have a LICENSE file containing the following license: \(workshop.license)") } | |||
| @@ -39,6 +40,7 @@ extension Workshop { | |||
| slidesLink = try builder.getSlidesLink() | |||
| tags = try builder.getTags() | |||
| license = try builder.getLicense() | |||
| hasLicense = try Workshop.getHasLicense(localPath: localPath) | |||
There was a problem hiding this comment.
This license / hasLicense thing looks a bit confusing.
Could you explain again the justification for having both the license ID in the metadata.yaml and the LICENSE text file? Maybe we should get rid of the license id
Alternatively, why not rename the license field on Workshop to licenseId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237.