Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separators to links section (#1444) #1486

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Add separators to links section (#1444) #1486

merged 6 commits into from
Apr 29, 2021

Conversation

DGnzl
Copy link
Contributor

@DGnzl DGnzl commented Apr 28, 2021

Added comma separators to the links section of the Projects page.

@DGnzl DGnzl linked an issue Apr 28, 2021 that may be closed by this pull request
2 tasks
@DGnzl
Copy link
Contributor Author

DGnzl commented Apr 28, 2021

Screen Shot 2021-04-28 at 8 42 25 AM

Screenshot of separators between links

Copy link
Member

@erikaBell erikaBell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DGnzl ~ The commas between the links look great! It appears issue #1444 also asks for comma separators to be added to the "Looking For" and "Technologies" sections of these cards. Could you add those in?

Also, please re-request review once these changes have been made, so I know to look over it again.

Thanks!

@DGnzl
Copy link
Contributor Author

DGnzl commented Apr 28, 2021

Screen Shot 2021-04-28 at 3 48 08 PM

Additional separators added.

@DGnzl DGnzl requested a review from erikaBell April 28, 2021 22:50
Copy link
Member

@erikaBell erikaBell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great @DGnzl

@erikaBell erikaBell merged commit ee4817b into hackforla:gh-pages Apr 29, 2021
@DGnzl DGnzl deleted the add-separators-to-links-1444 branch June 1, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Current Projects Page with separators
2 participants