Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates profile page by removing aletia trepte, case 5806 #5890

Merged
merged 1 commit into from
Nov 12, 2023
Merged

updates profile page by removing aletia trepte, case 5806 #5890

merged 1 commit into from
Nov 12, 2023

Conversation

sornekian
Copy link
Member

@sornekian sornekian commented Nov 9, 2023

Fixes #5806

What changes did you make?

  • Removed Aletia Trepte from profile page

Why did you make the changes (we will use this info to test)?

  • To update Lucky Parking profile page

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-11-09 at 1 44 38 PM
Visuals after changes are applied Screenshot 2023-11-09 at 1 45 53 PM

Copy link

github-actions bot commented Nov 9, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b sornekian-remove-trepte-5806 gh-pages
git pull https://github.com/sornekian/website.git remove-trepte-5806

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/sornekian/website/blob/remove-trepte-5806/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 9, 2023
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sornekian great work the changes specified in the issue are correctly done, just make some changes so that the PR is perfect,

  • In the reason for changes made mention to update the Lucky Parking profile page, I think this will be apt
  • Also if possible can you please add desktop screenshots, they will be little easier for reviewer and your PR can be reviewed
    Just change the above mentioned suggestions and I will approve it !!!

@sornekian
Copy link
Member Author

sornekian commented Nov 10, 2023

Hey @sornekian great work the changes specified in the issue are correctly done, just make some changes so that the PR is perfect,

  • In the reason for changes made mention to update the Lucky Parking profile page, I think this will be apt
  • Also if possible can you please add desktop screenshots, they will be little easier for reviewer and your PR can be reviewed
    Just change the above mentioned suggestions and I will approve it !!!

Hey, I appreciate the comments. For the desktop, I'm not sure how to view the local host on docker aside from opening it within the browser. Any suggestions?

@freaky4wrld freaky4wrld self-requested a review November 11, 2023 07:24
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sornekian I was just asking you to provide, full window screenshots, well doesn't matter that much. I'll approve this PR looks fine to me

@freaky4wrld freaky4wrld self-requested a review November 11, 2023 07:31
@t-will-gillis t-will-gillis self-requested a review November 12, 2023 17:33
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sornekian great work!

  • Your branches from/to are good
  • You're linked to original issue
  • You are providing a concise description of what you did and why
  • You are providing relevant before and after screenshots
  • Your code edits change only what needs to be changed

Thank you for working with @freaky4wrld to address the requested corrections.

@t-will-gillis t-will-gillis merged commit 4a4f1b0 into hackforla:gh-pages Nov 12, 2023
11 checks passed
@sornekian sornekian deleted the remove-trepte-5806 branch November 12, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Lucky Parking (Remove Aletia Trepte)
3 participants