-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates profile page by removing aletia trepte, case 5806 #5890
updates profile page by removing aletia trepte, case 5806 #5890
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sornekian great work the changes specified in the issue are correctly done, just make some changes so that the PR is perfect,
- In the
reason for changes made
mentionto update the Lucky Parking profile page
, I think this will be apt - Also if possible can you please add desktop screenshots, they will be little easier for reviewer and your PR can be reviewed
Just change the above mentioned suggestions and I will approve it !!!
Hey, I appreciate the comments. For the desktop, I'm not sure how to view the local host on docker aside from opening it within the browser. Any suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sornekian I was just asking you to provide, full window screenshots, well doesn't matter that much. I'll approve this PR looks fine to me
- Merging branch is correct
- Deletion of file content is done properly
And that's good to go!! Make sure to check off the underlying dependency on Update Project Profile: Lucky Parking (Remove Aletia Trepte) #5806
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sornekian great work!
- Your branches from/to are good
- You're linked to original issue
- You are providing a concise description of what you did and why
- You are providing relevant before and after screenshots
- Your code edits change only what needs to be changed
Thank you for working with @freaky4wrld to address the requested corrections.
Fixes #5806
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied