Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Slack image with svg icon in "Getting Started" Page #5892

Conversation

agutiernc
Copy link
Member

Fixes #5830

What changes did you make?

  • Replaced the slack image icon with an svg file icon on steps 2, 4, and 5
  • Modified CSS to align the icon and make responsive

Why did you make the changes (we will use this info to test)?

  • To update icon in svg format
  • To reduce redundancy in code on the getting started page
  • Make it simpler to change out the icon for a newer icon

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied

before-slack-icon-step2
before-slack-icon-step4-5

Visuals after changes are applied

after-slack-icon-step2
after-slack-icon-step4-5

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b agutiernc-refactor-getting-started-slack-icon-5830 gh-pages
git pull https://github.com/agutiernc/website.git refactor-getting-started-slack-icon-5830

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/agutiernc/website/blob/refactor-getting-started-slack-icon-5830/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 1pt Can be done in 4-6 hours labels Nov 12, 2023
@agutiernc agutiernc force-pushed the refactor-getting-started-slack-icon-5830 branch from 3f42e97 to 71319d7 Compare November 12, 2023 07:19
@agutiernc
Copy link
Member Author

Ignore this pull request. Need to resolve a git issue. Will create a new pull request later.

@agutiernc agutiernc closed this Nov 12, 2023
@agutiernc agutiernc deleted the refactor-getting-started-slack-icon-5830 branch November 13, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor HTML P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Getting Started" page to replace slack-join-meeting-channel.svg with icon-slack.svg
2 participants