Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove comment from contributing.md #5915

Merged

Conversation

jackyuan1
Copy link
Member

Fixes #5589

What changes did you make?

  • Removed old comment from contributing.md 1.6

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jackyuan1-remove-comment-contributing-5589 gh-pages
git pull https://github.com/jackyuan1/website.git remove-comment-contributing-5589

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jackyuan1/website/blob/remove-comment-contributing-5589/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Nov 16, 2023
@KyleA99 KyleA99 self-requested a review November 18, 2023 07:23
Copy link
Member

@KyleA99 KyleA99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your "after-images" in the PR description are of the wrong section, but all of the other content of the PR is correct.

  • Your PR is done with the correct branch.
  • Your code is correctly changed.
  • Changes look great in your live-link.

Reviewed and approved!

Great work @jackyuan1

@roslynwythe roslynwythe requested a review from tonyvang November 19, 2023 18:10
@tonyvang
Copy link
Contributor

Review ETA: will take a look tomorrow evening
Availability: Tuesday evening, Wednesday evening

Copy link
Contributor

@tonyvang tonyvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request is branched appropriately, has the issue linked, includes appropriately changed code that appears to make the intended visual change to the wiki page. I was also a little thrown off by the after screenshot as @KyleA99 mentioned, but I can see that the last line of text from before the removed note is visible at the top of the screenshot, showing that the note was removed. Well done and thank you for contributing! Approved.

@kwangric kwangric merged commit 30e103e into hackforla:gh-pages Nov 22, 2023
10 checks passed
@jackyuan1 jackyuan1 deleted the remove-comment-contributing-5589 branch November 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "good second issue" from CONTRIBUTING.md Section 1.6.a
4 participants