-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove hkatz & added zaranylucas from engineering cop #5917
remove hkatz & added zaranylucas from engineering cop #5917
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: Evenings |
Availability: M-F 6-9pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Tony
Nice work on your pull request
• Your created a branch using the correct syntax
• you correctly linked your issue and the the changes you made are clear to understand
• you correctly implemented the changes by updating the leadership variable from line 28-33
visually everything looks really good! keep up the good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tonyvang changes you made are as specified in the issue, and displays the changes correctly, the correct profile is deleted and the specified one is added.
The to/from branch are correct, the linked issue is correct as well.
Great work there..... PR approved
Fixes #5876
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied