Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hkatz & added zaranylucas from engineering cop #5917

Conversation

tonyvang
Copy link
Contributor

Fixes #5876

What changes did you make?

  • in _data/internal/communities/engineering.yml, removed Harrison Katz block from leadership section and added Zeke Arany-Lucas block

Why did you make the changes (we will use this info to test)?

  • in re issue 5876
  • to keep project information up-to-date and accurate

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image
Screenshot (17)

Visuals after changes are applied

image
Screenshot (18)

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b tonyvang-eng-cop-up-remove-hkatz-add-zaranylucas-5876 gh-pages
git pull https://github.com/tonyvang/website.git eng-cop-up-remove-hkatz-add-zaranylucas-5876

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/tonyvang/website/blob/eng-cop-up-remove-hkatz-add-zaranylucas-5876/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 17, 2023
@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: EOD 11/18

@Chrisklangley Chrisklangley self-requested a review November 18, 2023 01:38
@Chrisklangley
Copy link
Contributor

Availability: M-F 6-9pm
ETA: 11/18/23 EOD

Copy link
Contributor

@Chrisklangley Chrisklangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tony

Nice work on your pull request
• Your created a branch using the correct syntax
• you correctly linked your issue and the the changes you made are clear to understand
• you correctly implemented the changes by updating the leadership variable from line 28-33

visually everything looks really good! keep up the good work

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tonyvang changes you made are as specified in the issue, and displays the changes correctly, the correct profile is deleted and the specified one is added.
The to/from branch are correct, the linked issue is correct as well.
Great work there..... PR approved

@t-will-gillis t-will-gillis merged commit b942a5a into hackforla:gh-pages Nov 19, 2023
10 checks passed
@tonyvang tonyvang deleted the eng-cop-up-remove-hkatz-add-zaranylucas-5876 branch January 16, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Communities of Practice: Engineering (Remove Harrison Katz, Add Zeke Arany-Lucas)
4 participants