Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email link in privacy-policy.yml for Questions section #7462

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix email link in privacy-policy.yml for Questions section #7462

merged 1 commit into from
Sep 18, 2024

Conversation

bexux
Copy link
Member

@bexux bexux commented Sep 15, 2024

Fixes #7412

What changes did you make?

Under the Questions section of the privacy-policy.yml file, I have added mailto: to the email link.

Why did you make the changes (we will use this info to test)?

Adding mailto: will allow users to easily send an email when they click this link instead of going to a 404 page.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

There were no style changes affecting the website, but I have attached screen shots of the behavior changes when clicking the link.

Visuals before changes are applied
Visuals after changes are applied

image

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bexux-fix-privacy-policy-email-7412 gh-pages
git pull https://github.com/bexux/website.git fix-privacy-policy-email-7412

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy size: 0.5pt Can be done in 3 hours or less labels Sep 15, 2024
@FamousHero FamousHero self-requested a review September 16, 2024 00:07
@FamousHero
Copy link
Member

Review ETA: EOD (9/16)
Availability: 5-6 PM Monday-Friday

@8alpreet 8alpreet self-requested a review September 16, 2024 23:47
@8alpreet
Copy link
Member

8alpreet commented Sep 16, 2024 •
edited
Loading

Availability: Weekdays 3-7 pm PST.
ETA: 7pm Mon, Sep 17, 2024

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bexux-fix-privacy-policy-email-7412 gh-pages
git pull https://github.com/bexux/website.git fix-privacy-policy-email-7412

FamousHero
FamousHero reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a duplicate of #7411. Will cause a Merge Confilct. Both #7411 and #7412 were initiated by #7108. @hackforla/website-merge Can anyone confirm?

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 17, 2024 •
edited
Loading

@FamousHero If you look closely, these are not duplicates and each issue references a specific section. There should be no merge conflicts because each issue is working on a different section.

8alpreet
8alpreet approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@8alpreet 8alpreet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bexux,

Everything looks great!

  • descriptive but concise title
  • issue is linked
  • branch is named correctly
  • only relevant code is changed
  • PR comment is excellent

FamousHero
FamousHero approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-will-gillis Got it. Also checking it on my machine looks good.

  • branch name descriptive & contains issue #
  • Changes & reason are short and concise
  • Behavioral changes match what was described
    Good job!

mmcclanahan
mmcclanahan approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@mmcclanahan mmcclanahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Completed:
To/From branch are correct
Clear PR name
What/Why are descriptive
Documented the link working with pictures

Looks good!

@mmcclanahan mmcclanahan mentioned this pull request Sep 18, 2024
Open
@8alpreet 8alpreet mentioned this pull request Sep 18, 2024
Open
@Thinking-Panda
Copy link
Member

@bexux , Thank you for working on this issue.

@Thinking-Panda Thinking-Panda merged commit 6ec67cf into hackforla:gh-pages Sep 18, 2024
6 checks passed
@FamousHero FamousHero mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcclanahan mmcclanahan mmcclanahan approved these changes

@FamousHero FamousHero FamousHero approved these changes

@8alpreet 8alpreet 8alpreet approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix mail links for Questions in privacy-policy.yml
6 participants
@bexux @FamousHero @8alpreet @t-will-gillis @Thinking-Panda @mmcclanahan