Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lola Sarumi to Home Unite Us leadership #7511

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

chrjl
Copy link
Member

@chrjl chrjl commented Sep 24, 2024

Fixes #7488

What changes did you make?

  • Added Lola Sarumi's profile to Home Unite Us leadership (home-unite-us.md frontmatter).

Why did you make the changes (we will use this info to test)?

  • So current team members can be properly displayed on the Hack for LA website.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2024-09-23 at 16-54-21 Home Unite Us - Hack for LA

Visuals after changes are applied

Screenshot 2024-09-23 at 16-54-49 Home Unite Us - Hack for LA

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b chrjl-update-homeuniteus-profile-7488 gh-pages
git pull https://github.com/chrjl/hackforla--website.git update-homeuniteus-profile-7488

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 24, 2024
@terrencejihoonjung
Copy link
Member

availability: everyday, 5pm - 9pm PST
eta: today, 11:59pm PST

@codyyjxn codyyjxn self-requested a review September 24, 2024 19:52
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrjl Thank you for taking on this issue. The branch is named correct. The changes are good and the visuals are great I am able to see what you fixed. Congrats on your first good issue.

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrjl,

  • changes made and why they were made are clearly stated
  • branch naming is correct
  • visual changes made displayed correctly
  • PR title clear and concise

Thanks for your contribution!

@LRenDO LRenDO merged commit 57bd250 into hackforla:gh-pages Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Add Lola Sarumi
4 participants