Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating contributing.md section 3.1.b.i issue#7641 #7816

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

purna-madala
Copy link
Member

@purna-madala purna-madala commented Jan 6, 2025

Fixes #7641

What changes did you make?

  • changed section 3.1.b.i lines 913-922 with requested changes

Why did you make the changes (we will use this info to test)?

  • updated the contributing information

For Reviewers:

  • Do not review changes locally, rather, review changes at [https://github.com/purna-madala/website/blob/update-contributing-issue-7641/CONTRIBUTING.md]

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

github-actions bot commented Jan 6, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/purna-madala/website/blob/update-contributing-issue-7641/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Jan 6, 2025
@DrAcula27 DrAcula27 self-requested a review January 6, 2025 22:53
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purna-madala Great job on your Small Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file CONTRIBUTING.md was edited
  • No extra edits were made
  • Appearance of the website is unchanged (Chrome and Firefox)
    Approved! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Status: PR Needs review
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md Section 3.1.b.i
2 participants