-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Profile HFLA Website Essence Goff #7845
base: gh-pages
Are you sure you want to change the base?
Add Profile HFLA Website Essence Goff #7845
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 6 PM 1/25/25 |
Hi @Eddysunday012 , Great job on adding the new profile variable—your implementation looks solid and addresses the issue effectively. However, I noticed that there are several instances where single quotes have been changed to double quotes throughout the codebase. These formatting changes aren’t related to the current scope of this issue or PR. Could you please revert the quote changes and just keep the changes that you have made from line 15-21? Keeping PRs focused helps maintain clarity and makes the review process smoother for everyone involved. Thanks for your understanding! |
Thank you @maadeshsivakumar for reviewing my PR! I undid the changes to the single quotes and only kept the changes for lines 15-21 just like you recommended! I think I accidentally had my prettier extension change it by default when I saved 😅 |
@acterin, please comment with your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eddysunday012 !
This looks great!
- The branches from and to are setup correctly
- Link to the issue is included
- There is a clear and concise description of what was done and why
- Visual changes look good
Thank you for your contribution! :)
picture: https://avatars.githubusercontent.com/ExperimentsInHonesty | ||
- name: Essence Goff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eddysunday012 ,
Great job on adding the new profile variable—your implementation looks solid and addresses the issue effectively.
However, I noticed that there are several instances where single quotes have been changed to double quotes throughout the codebase. These formatting changes aren’t related to the current scope of this issue or PR.
Could you please revert the quote changes and just keep the changes that you have made from line 15-21? Keeping PRs focused helps maintain clarity and makes the review process smoother for everyone involved.
Thanks for your understanding!
Fixes #7754
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied