-
Notifications
You must be signed in to change notification settings - Fork 176
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
6 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
__version__ = "0.5.3" | ||
__version__ = "0.5.4" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that for some reason, your Pypi file is still 55 Mb. That is huge. I think you need to ensure that the test files are exclyded.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a python setup.py sdist. I get a tar.gz file that is only 1Mb. So something funky is going on with the Pypi version of the file.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[shrugs]] - no idea.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like all 'test' folders are excluded but not 'test_files'
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vasp/test_files ~ 75MB
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MANIFEST.in says global-exclude atomate tests/. test_files/. tests/* test_files/*.
Also, given that the previous includes only covers *.py and *.yaml files, the test files which do not conform to these formats should not have been included in the first place.
Why don't you run a python setup.py sdist to confirm whether they are included or not. You may want to clear your build and dist directories first.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just ran sdist, it does include test_files!
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... I am confused then. I ran it on my machine and it does not include test_files.
I am on py 3.6.2. Are you on the same or Py2?
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, pls clean out build, dist and egg-info first.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.5, i did remove those folders..
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind.. forgot to remove egg-info..now it doesnt include test_files
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something really funky is going on then. I consistently get 1Mb....
Anyway, I don't care too much about the mechanics of it.
Why don't you edit the MANIFEST.in until you are able to get a 1Mb file. Then commit. It probably just requires some more exclude commands.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. So that stupid egg-ingo is the problem. @computron You have your solution. Just delete the old egg-info first.
2041273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly related mgedmin/check-manifest#1