Skip to content

Commit

Permalink
update to v0.5.4
Browse files Browse the repository at this point in the history
  • Loading branch information
computron committed Jul 21, 2017
1 parent 4cf0362 commit 2041273
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion atomate/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.5.3"
__version__ = "0.5.4"
4 changes: 4 additions & 0 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
atomate Changelog
=================

**v0.5.4**

* re-attempt to fix packaging of YAML workflow library in pip

**v0.5.3**

* attempt to fix packaging of YAML workflow library in pip
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
if __name__ == "__main__":
setup(
name='atomate',
version='0.5.3',
version='0.5.4',
description='atomate has implementations of FireWorks workflows for '
'Materials Science',
long_description=open(os.path.join(module_dir, 'README.rst')).read(),
Expand Down

15 comments on commit 2041273

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that for some reason, your Pypi file is still 55 Mb. That is huge. I think you need to ensure that the test files are exclyded.

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a python setup.py sdist. I get a tar.gz file that is only 1Mb. So something funky is going on with the Pypi version of the file.

@computron
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[shrugs]] - no idea.

@bocklund
Copy link
Contributor

@bocklund bocklund commented on 2041273 Jul 21, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matk86
Copy link
Contributor

@matk86 matk86 commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like all 'test' folders are excluded but not 'test_files'

@matk86
Copy link
Contributor

@matk86 matk86 commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vasp/test_files ~ 75MB

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MANIFEST.in says global-exclude atomate tests/. test_files/. tests/* test_files/*.

Also, given that the previous includes only covers *.py and *.yaml files, the test files which do not conform to these formats should not have been included in the first place.

Why don't you run a python setup.py sdist to confirm whether they are included or not. You may want to clear your build and dist directories first.

@matk86
Copy link
Contributor

@matk86 matk86 commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just ran sdist, it does include test_files!

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I am confused then. I ran it on my machine and it does not include test_files.
I am on py 3.6.2. Are you on the same or Py2?

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, pls clean out build, dist and egg-info first.

@matk86
Copy link
Contributor

@matk86 matk86 commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5, i did remove those folders..

@matk86
Copy link
Contributor

@matk86 matk86 commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind.. forgot to remove egg-info..now it doesnt include test_files

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something really funky is going on then. I consistently get 1Mb....
Anyway, I don't care too much about the mechanics of it.
Why don't you edit the MANIFEST.in until you are able to get a 1Mb file. Then commit. It probably just requires some more exclude commands.

@shyuep
Copy link
Collaborator

@shyuep shyuep commented on 2041273 Jul 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. So that stupid egg-ingo is the problem. @computron You have your solution. Just delete the old egg-info first.

@bocklund
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly related mgedmin/check-manifest#1

Please sign in to comment.