Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups for SHA2 in preparation of the next Python PR #773

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Conversation

msprotz
Copy link
Contributor

@msprotz msprotz commented Feb 8, 2023

This is basically replicating some of the work that I did for sha2-224/256 onto sha2-384/512:

  • add a copy function
  • write spec equivalence proofs so as to enable code sharing between sha2-384 and sha2-512

This is all in preparation for python/cpython#101707

@msprotz msprotz requested a review from a team as a code owner February 8, 2023 22:43
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

[CI] Important!
The code in dist/gcc-compatible, dist/msvc-compatible, and dist/wasm
is tested on cryspen/hacl-packages.
dist is not automatically re-generated, be sure to do it manually.
(A fresh snapshot can also be downloaded from CI.)
Then check the following tests before merging this PR.
Always check the latest run, it corresponds to the most recent version of this branch.
All jobs are expected to be successful.
In some cases manual intervention is needed. Please ping the hacl-packages maintainers.

  • Build, Test, Benchmark: Build on Linux (x86, x64), Windows (x86, x64), MacOS (x64, arm64), s390x, Android (arm64) and test on Linux (x86, x64), Windows (x86, x64), MacOS (x64).
  • Performance Regression Tests: Navigate to the terminal output in “Run benchmarks”. The comparison with the main branch will be at the bottom. The run fails if the performance regresses too much.
  • OCaml bindings: Build & Tests
  • JS bindings: Build & Tests
  • Rust bindings: Build & Tests

@msprotz
Copy link
Contributor Author

msprotz commented Feb 8, 2023

Sadly, there's a lot of whitespace changes because of the latest krml changes

Copy link
Contributor

@R1kM R1kM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@polubelova polubelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@polubelova polubelova merged commit aaf10ea into main Feb 9, 2023
@polubelova polubelova deleted the protz_sha2 branch February 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants