Retry login after intervals specified by the server #94
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleep for the duration indicated by the server on M_LIMIT_EXCEEDED responses, or immediately if no time specified.
aperezdc
force-pushed
the
login-retry-later
branch
from
21d182e to
cd93269
Compare
|
Since the issue only occurred with a malfunctioning homeserver, and never caused any issue anywhere else, I think this extra code is not needed. I also don't think that this quite simple bot is able to get rate limited with |
Agreed, this helped debug a particular issue with our homeserver, but in general I would not expect people to hit a rate-limit situation during login in normal operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sleep for the duration indicated by the server on
M_LIMIT_EXCEEDEDresponses, or immediately if no time specified.