Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add !publish_command #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-kenji
Copy link

@a-kenji a-kenji commented Feb 17, 2025

Add an optional !publish_command that can be configured. It will get the generated rendered markdown through stdin. If the command has some output it will be sent to the admin channel as a message.

This can be useful for more robust publishing practices.

Add an optional `!publish_command` that can be configured.
It will get the generated rendered markdown through stdin.
If the command has some output it will be sent to the admin channel as a
message.
.await;
}

// Generate a curl command which can get used to download all files (images/videos).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curl part will disappear very soon, as it doesn't work anymore with Matrix authed media repositories. Probably in future we'll bundle all the files as a downloadable ZIP file. See #93 for more details.

Beside that, I think from a logical point of view a !publish command also should be able to handle the files, and not "just" the rendered text via stdin.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it makes sense to wait for #93 getting fixed, so we can see what's the best way how we can deal with the media files. Would be neat if you could fully automate the publishing with it, images and videos included.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback.

Would be neat if you could fully automate the publishing with it, images and videos included.

Yes, that would be ideal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants