Add support for vault aws iam auth #1607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces support for the iam flavor of vault's aws auth engine. While the referenced, unmerged PR introduces a similar feature set, this implementation opts for using the same go libraries used by the vault cli for generating the login parameters. related-pr: hairyhenderson#191
|
@cludden thanks for working on this, however it would've been ideal if you'd opened an issue first... In gomplate v4, which will hopefully be the next release, I'm moving over to use go-fsimpl for all datasources, and the I've been (slowly) working on incorporating that in #1336. |
|
I normally would have, but saw there was an open, but very out-of-date PR for this very feature, so referenced that in my commit instead. Happy to close this in favor of the upcoming v4 implementation.. |
|
@cludden ok, fair enough! thanks for understanding 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces support for the iam flavor of vault's aws auth engine. While the referenced, unmerged PR introduces a similar feature set, this implementation opts for using the same go libraries used by the vault cli for generating the login parameters.
related-pr: #191