Consul vault auth #187
Merged
Consul vault auth #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuart-c
force-pushed
the
consul-vault-auth
branch
9 times, most recently
from
72befc4 to
2550cd9
Compare
|
@stuart-c this looks good so far, but will need to be rebased |
stuart-c
force-pushed
the
consul-vault-auth
branch
4 times, most recently
from
243ebbf to
f595f51
Compare
stuart-c
force-pushed
the
consul-vault-auth
branch
from
f595f51 to
6b4f08e
Compare
|
@hairyhenderson I think this one should be ready too... |
|
Thanks @stuart-c 😁 |
|
Thanks! Would it be possible to cut a release with the recent changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #177 to be merged first.
Add ability to get Consul token from Vault dynamic secret backend