Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gomplateignore support #225

Merged
merged 14 commits into from
Feb 2, 2019
Merged

Add .gomplateignore support #225

merged 14 commits into from
Feb 2, 2019

Conversation

zealic
Copy link
Contributor

@zealic zealic commented Nov 2, 2017

For #218

@hairyhenderson
Copy link
Owner

Thanks for this, @zealic! When I have a little more time I'll review this more fully, but in the meantime can you add an integration test? Have a look at the existing .bats files in test/integration/ for inspiration. You can run the tests with test-integration-docker. I'm mostly looking for automated confirmation that the compiled binary processes .gomplateignore files as expected.

@zealic
Copy link
Contributor Author

zealic commented Nov 3, 2017

OK, I will try add integration tests. @hairyhenderson

zealic added 5 commits January 30, 2019 17:27
@zealic
Use xignore to support .gomplateignore.
f0e7488
@zealic
Adding intgegration tests for .gomplateignore
8d13b8b
@zealic
Use AfterPatterns to replace default exclude option implement.
7111f80
@zealic
Merge branch 'feature-gomplateignore' into add-gomplateignore
7c34633 
# Conflicts:
#	Gopkg.lock
#	Gopkg.toml
#	process.go
#	process_test.go
#	vendor/github.com/zealic/xignore/ignorefile.go
#	vendor/github.com/zealic/xignore/matcher.go
#	vendor/github.com/zealic/xignore/xignore.go
@zealic
* Fix lint issue.
bb8c369
@zealic
Copy link
Contributor Author

zealic commented Jan 30, 2019

Integration tests added, please review and merge.

hairyhenderson
hairyhenderson reviewed Jan 30, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
@hairyhenderson
Copy link
Owner

Thanks for updating this, @zealic! I'll be able to take a deeper look in a few hours, hopefully.

hairyhenderson
hairyhenderson reviewed Feb 2, 2019
View reviewed changes
template.go Outdated Show resolved Hide resolved
@hairyhenderson
Copy link
Owner

Thanks @zealic! And, thanks especially for your persistence in getting this in - I know it took a very long time! 😉

@hairyhenderson hairyhenderson merged commit d187344 into hairyhenderson:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairyhenderson hairyhenderson hairyhenderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zealic @hairyhenderson