Adding sockaddr namespace #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
add-sockaddr-funcs-145
branch
2 times, most recently
from
88675f5 to
97cd199
Compare
sean-
approved these changes
Mar 4, 2018
funcs/sockaddr.go
Outdated
| sockaddrNSInit sync.Once | ||
| ) | ||
|
|
||
| // SockaddrNS - the crypto namespace |
There was a problem hiding this comment.
😂 good old copy-pasta 🍝
test/integration/sockaddr_test.go
Outdated
| {{ . | sockaddr.Attr "address" }} | ||
| {{end}}`) | ||
| result.Assert(c, icmd.Expected{ExitCode: 0, Out: "127.0.0.1"}) | ||
| } |
There was a problem hiding this comment.
I need to go back and write a helper function that's builtin to go-sockaddr that makes testing easier.
There was a problem hiding this comment.
the ability to inject some fake interface/address state to go-sockaddr would be useful for testing, but not entirely crucial...
hairyhenderson
force-pushed
the
add-sockaddr-funcs-145
branch
from
97cd199 to
8cedf44
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
add-sockaddr-funcs-145
branch
from
00949cf to
f798294
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
add-sockaddr-funcs-145
branch
from
f798294 to
95d516d
Compare
hairyhenderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
Adds a pile of functions from the
go-sockaddrpackage:sockaddr.GetAllInterfacessockaddr.GetDefaultInterfacessockaddr.GetPrivateInterfacessockaddr.GetPublicInterfacessockaddr.Sortsockaddr.Excludesockaddr.Includesockaddr.Attrsockaddr.Joinsockaddr.Limitsockaddr.Offsetsockaddr.Uniquesockaddr.Mathsockaddr.GetPrivateIPsockaddr.GetPrivateIPssockaddr.GetPublicIPsockaddr.GetPublicIPssockaddr.GetInterfaceIPsockaddr.GetInterfaceIPsI tried to closely match the function names that are exported in github.com/hashicorp/go-sockaddr/template, though couldn't directly import the
FuncMaps defined therein, because I'd like these to be namespaced./cc @jen20 @sean-