No vault addr dont panic #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,23 @@ | |||
| package vault | |||
There was a problem hiding this comment.
can you throw these into client_test.go?
drmdrew
force-pushed
the
no-vault-addr-dont-panic
branch
from
9923ef9 to
3e775e9
Compare
|
Removed |
| @@ -81,9 +89,13 @@ func (c *Client) Do(req *http.Request) (*http.Response, error) { | |||
|
|
|||
| // Login - log in to Vault with the discovered auth backend and save the token | |||
| func (c *Client) Login() error { | |||
| if c.Auth == nil { | |||
There was a problem hiding this comment.
Can you move this check inside getAuthStrategy()?
drmdrew
force-pushed
the
no-vault-addr-dont-panic
branch
from
b826f5e to
456eebd
Compare
|
Moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt at a fix for #84. PTAL @hairyhenderson
This time, rather than twisting gomplate into a pretzel trying to propagate errors, a small testing hack is being made to allow
log.Fatalto be overwritten inside tests to inject a mock/spy that doesn't cause the process to exit.Added unit tests and also checked on the command-line that gomplate doesn't panic when some/all of the
VAULT_*environment variables are missing: