Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support: Windows OS. #116

Merged
merged 18 commits into from
Sep 26, 2020
Merged

Support: Windows OS. #116

merged 18 commits into from
Sep 26, 2020

Conversation

hadialqattan
Copy link
Contributor

Solve both #110 and #104 .

@hadialqattan
Copy link
Contributor Author

Hi @hakancelik96 , all tests passed except the pre-commit hooks!

I think there's a problem with the pre-commit hooks!

@hadialqattan
Copy link
Contributor Author

Hi @hakancelik96 , all tests passed except the pre-commit hooks!

I think there's a problem with the pre-commit hooks!

I don't know where the problem is, but black on the pre-commit (locally) runs with the default args (--line-length=88) instead of (--line-length=79)!

I've blackened the PR by running black . --line-length=79 manually, and as you see everything is fine!

@hadialqattan
Copy link
Contributor Author

hadialqattan commented Sep 25, 2020 •
edited
Loading

Anyway, the Windows OS has supported!

I'm waiting for your reviews!
@hakancelik96
@isidentical

@hadialqattan
Copy link
Contributor Author

@hakancelik96 kindly please link this PR to #110 and #104

This was linked to issues Sep 25, 2020
Adding WindowsOS to the CI pipeline. #110
Closed
diff option should produce a usable patch #104
Closed
hakancelikdev
hakancelikdev requested changes Sep 26, 2020
View reviewed changes
@hakancelikdev
Copy link
Owner

Why does Codecov not work when a non-member of the repo send a PR? Do you have any idea

@hadialqattan
Copy link
Contributor Author

Why does Codecov not work when a non-member of the repo send a PR? Do you have any idea

Unfortunately, I don't have any idea, but I'll try to solve it as soon as I have enough time for that.

@hakancelikdev
Copy link
Owner

Thank you for your great contribution 💯

@hakancelikdev hakancelikdev merged commit 5c21397 into hakancelikdev:master Sep 26, 2020
@hadialqattan hadialqattan deleted the i110 branch September 26, 2020 15:02
@hakancelikdev
Copy link
Owner

hakancelikdev commented Sep 27, 2020 •
edited
Loading

Why does Codecov not work when a non-member of the repo send a PR? Do you have any idea

Unfortunately, I don't have any idea, but I'll try to solve it as soon as I have enough time for that.

@hadialqattan codecov/codecov-action#29

hakancelikdev pushed a commit that referenced this pull request Jul 16, 2022
@hadialqattan
Support: Windows OS. (#116)
afee861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakancelikdev hakancelikdev hakancelikdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding WindowsOS to the CI pipeline. diff option should produce a usable patch
2 participants
@hadialqattan @hakancelikdev