Added Gulp #2122
Merged
Added Gulp #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have created a gulpfile.js with the same tasks of grunt, replaced npm script and finally ad .jshintrc for jshint
I forgot them 😧
|
Thanks for this PR. I think |
I added the same jshint configuration/rules in package.json and I replaced some old function with arrow function to improve legibility
|
And voila! |
|
I know this is very old, but may I ask why Grunt is still in the PR? I would expect Grunt to be replaced by Gulp instead of living side-by-side in this PR. Also, I see NPM was added as a dependency. I don't think it is a good practice to have NPM as a dependency because of multiple reasons. For example, what if the user wants to use Yarn? Also, jshint is still listed as a dependency and eslint is not. |
|
This has been merged, thanks! I made a couple of changes to the tasks and still need to get the tests working. I'll also be removing grunt, so as of reveal.js 4.0 gulp will be the way to go 🙌 |
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a
gulpfile.jswith the same tasks of grunt, replacednpm scriptand finally added.jshintrc