Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctness/atomics.cpp fails with CUDAVectorize engine #4554

Closed
alexreinking opened this issue Jan 26, 2020 · 3 comments · Fixed by #5286
Closed

correctness/atomics.cpp fails with CUDAVectorize engine #4554

alexreinking opened this issue Jan 26, 2020 · 3 comments · Fixed by #5286
Assignees
Labels

Comments

@alexreinking
Copy link
Member

When running correctness/atomics.cpp with cuda enabled, llvm 9.0.1, and using the CMake build, the following happens:

alex@alex-ubuntu:~/Development/Halide/cmake-build-debug$ ./bin/correctness_atomics 
Error:
Line 244: Expected 77 instead of 76
Aborted (core dumped)

The CMake build is necessary because it defines LLVM_VERSION=90, whereas the Makefile doesn't.

HL_[JIT_]TARGET=x86-64-linux-cuda

@shoaibkamil
Copy link
Contributor

Relatedly, this seems to be failing windows buildbots as well.

@alexreinking
Copy link
Member Author

#4683 disabled these tests. Code comments suggest #4628 will provide a fix.

@alexreinking
Copy link
Member Author

Since #4628 landed, I wonder if these tests work again?

// TODO: Broken currently; commented out until https://github.com/halide/Halide/pull/4628 lands
// test_all<uint32_t>(Backend::CUDAVectorize);
// test_all<int32_t>(Backend::CUDAVectorize);
// test_all<float>(Backend::CUDAVectorize);
// test_all<uint64_t>(Backend::CUDAVectorize);
// test_all<int64_t>(Backend::CUDAVectorize);
// test_all<double>(Backend::CUDAVectorize);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants