Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on PIP/Conda #5360

Closed
alexreinking opened this issue Oct 14, 2020 · 8 comments · Fixed by #8405
Closed

Publish on PIP/Conda #5360

alexreinking opened this issue Oct 14, 2020 · 8 comments · Fixed by #8405
Assignees
Labels
build Issues related to building Halide and with CI enhancement New user-visible features or improvements to existing features.
Milestone

Comments

@alexreinking
Copy link
Member

alexreinking commented Oct 14, 2020

I'm splitting this out from the generic #4660 issue. We should investigate packaging Halide and especially the Python bindings for either or both of PIP and Conda.

Ideally these would be cross-platform wheels for Windows, macOS, and Linux (via the manylinux images). We probably only need to support Python 3.8+, which is good since #4876 affects the autoschedulers on Windows.

@alexreinking alexreinking added enhancement New user-visible features or improvements to existing features. build Issues related to building Halide and with CI labels Oct 14, 2020
@alexreinking alexreinking modified the milestones: v11.0.0, v12.0.0 Oct 17, 2020
@dragly
Copy link
Contributor

dragly commented Jan 27, 2021

@alexreinking has there been any concrete progress or made any plans regarding this issue? I am interested in contributing to solving this issue for PIP. I am starting to rely more on the Python bindings for Halide, and having official packages available would simplify a few common hurdles I have currently (like distributing the Python extension files with scripts).

@BachiLi
Copy link
Contributor

BachiLi commented Jan 27, 2021

@dragly I was supposed to work on this, but haven't got the time to do this at all. I'm happy to work with you and Alex to make this happen.

@steven-johnson
Copy link
Contributor

I am interested in contributing to solving this issue for PIP.

We'd love to have contributions in this regard.

@tyoc213
Copy link

tyoc213 commented Jan 31, 2021

I think I have one option that can serve to pip and conda, can make initial PR or just say what is the option

@dragly
Copy link
Contributor

dragly commented Feb 1, 2021

Great! Did you have any particular solutions in mind? I was thinking of looking into using skbuild (scikit-build) in setup.py to invoke CMake, but am still a bit unsure if that should be a secondary step after building Halide first or if that should just build the entirety of Halide with Python bindings in one go.

I think I have one option that can serve to pip and conda, can make initial PR or just say what is the option

@tyoc213: Do you mean like a complete solution or an option like a CMake option? In any case, I am very interested in hearing your ideas or seeing your PR. It is just awesome if you have this solved already :)

@tyoc213
Copy link

tyoc213 commented Feb 1, 2021

Well not solved! only have a suguestion also pointed it here #4660 (comment) which is pypi_template which will work for conda and pip and you just need to add

@alexreinking alexreinking modified the milestones: v12.0.0, v13.0.0 Apr 16, 2021
@dragly
Copy link
Contributor

dragly commented Apr 12, 2023

It is really great to see that you have added a workflow to publish to PyPI 🙂 I am sorry I did not have time to help out with this myself.

It seems like the upload on the release is failing, which I added an issue for here: #7501

I guess this issue can also be closed if that is fixed?

@alexreinking
Copy link
Member Author

Fixed by #8405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to building Halide and with CI enhancement New user-visible features or improvements to existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants