Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads to PyPI not happening on release #7501

Closed
dragly opened this issue Apr 12, 2023 · 4 comments
Closed

Uploads to PyPI not happening on release #7501

dragly opened this issue Apr 12, 2023 · 4 comments
Assignees

Comments

@dragly
Copy link
Contributor

dragly commented Apr 12, 2023

Looking at the pypi.yml workflow in the latest version of the release/15.x branch, it seems at first glance like it should be invoked whenever a release is created:

https://github.com/halide/Halide/blob/4c63f1befa1063184c5982b11b6a2cc17d4e5815/.github/workflows/pip.yml

However, it seems like it was not run for 15.0.0 and 15.0.1. Any ideas on why it is not triggered?

@alexreinking
Copy link
Member

I think it's because it's untested and I was hesitant to upload anything to the Real PyPA when there were still issues on Test PyPA

@dragly
Copy link
Contributor Author

dragly commented Apr 13, 2023

That makes sense. Which issues remain on Test PyPA apart from being able to overwrite existing packages, i.e. #7293? I have been testing the one package that is one there quite a bit and it seems to work nicely 👍

@alexreinking
Copy link
Member

This should be fixed by #8405 but we'll know for sure when we tag the release!

@dragly
Copy link
Contributor Author

dragly commented Jan 6, 2025

Looks like it worked on Halide 19 release 🎉

https://pypi.org/project/halide/
image

Closing this issue since it seems to be resolved 👍

Thanks so much for adding Halide to PyPI!

@dragly dragly closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants