Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float16 inf checking is broken #8340

Closed
alexreinking opened this issue Jul 8, 2024 · 0 comments · Fixed by #8298
Closed

Float16 inf checking is broken #8340

alexreinking opened this issue Jul 8, 2024 · 0 comments · Fixed by #8298
Assignees
@alexreinking
Labels
bug

Comments

@alexreinking
Copy link
Member

Work on #8298 revealed that correctness_float16_t fails when arm_fp16 is enabled in the target.

HL_TARGET=host
HL_JIT_TARGET=host
#CTEST_RESOURCE_GROUP_COUNT=
/home/halidenightly/build_bot/worker/halide-testbranch-main-llvm19-arm-64-linux-cmake/halide-build/test/correctness/correctness_float16_t
Result 4 is 0 instead of 1
float16_t test failed!
Testing float16_t...
Required regular expression not found. Regex=[Success!]
alexreinking added a commit that referenced this issue Jul 8, 2024
@alexreinking
Fix Type::max() for float16
45cdceb 
Fixes #8340
@alexreinking alexreinking mentioned this issue Jul 8, 2024
Merged
@alexreinking alexreinking self-assigned this Jul 8, 2024
steven-johnson pushed a commit that referenced this issue Jul 15, 2024
@alexreinking @steven-johnson
Detect ARM CPU features for host target and in runtime (#8298)
23ce3eb 
Adds feature detection for ARM CPUs to the runtime library and to
the host target feature computation. Supports Windows, macOS,
Linux, iOS, and Android.

Also fix bug in Type::max() and Type::min() for float16.

Fixes #4727
Fixes #6106
Fixes #7901
Fixes #7979
Fixes #8340
@steven-johnson steven-johnson mentioned this issue Jul 15, 2024
Merged
steven-johnson added a commit that referenced this issue Jul 17, 2024
@steven-johnson @alexreinking
Detect ARM CPU features for host target and in runtime (Backport to r…
8c651b4 
…elease/18.x) (#8343)

Detect ARM CPU features for host target and in runtime (#8298)

Adds feature detection for ARM CPUs to the runtime library and to
the host target feature computation. Supports Windows, macOS,
Linux, iOS, and Android.

Also fix bug in Type::max() and Type::min() for float16.

Fixes #4727
Fixes #6106
Fixes #7901
Fixes #7979
Fixes #8340

Co-authored-by: Alex Reinking <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexreinking alexreinking

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect ARM CPU features for host target and in runtime halide/Halide
1 participant
@alexreinking