Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone of https://github.com/halide/Halide/pull/5545 for testing #5550

Closed
wants to merge 11 commits into from
Closed

Clone of https://github.com/halide/Halide/pull/5545 for testing #5550

wants to merge 11 commits into from

Conversation

steven-johnson
Copy link
Contributor

No description provided.

xndcn added 7 commits December 11, 2020 00:39
@xndcn
Fix disorder kernel args for OpenGL
6f72225 
OpenGL relies on the correct order of kernel args,
so we can only sort the args on non-OpenGL target.
@xndcn
Add support of less than 3 dimensions image_load for OpenGL
b072097 
See also this commit: #5297
@xndcn
Fix mismatch type of uniforms for OpenGL kernel args
8c2e82a 
OpenGL runtime will use raw type pointer to retrieve the uniform value in
kernel args, so we have to use C-style type definition instead of GLSL-style.

See also #4702
@xndcn
Add some variables to distinguish GL 2.x from GLCompute
b5cd6c8 
GL 2.x does not support uint/uvec and only a subset
of builtin functions support int/ivec arguments.
Besides, GLES does not define round of integer division.
@xndcn
Fix issue of precision loss for OpenGL uint texture loading
e5bee4f
@xndcn
Fix issue of VAO for OpenGL 3.x
2b26b6f 
VAO (vertex array object) must be bind before
vertex attribute array is enabled or disabled.
@xndcn
Fix remain errors in OpenGL tests
957b6bd 
Bypass integer division temporarily since the latest version is
far more complicated to list.
@steven-johnson steven-johnson mentioned this pull request Dec 11, 2020
Merged
@alexreinking
Copy link
Member 

ccache g++-7  -Wall -Werror -Wno-unused-function -Wcast-qual -Wignored-qualifiers -Wno-comment -Wsign-compare -Wno-unknown-warning-option -Wno-psabi -Wsuggest-override   -Woverloaded-virtual -fPIC -O3 -fno-omit-frame-pointer -DCOMPILING_HALIDE -std=c++11  -I/home/halidenightly/build_bot/worker/llvm-11-x86-64-linux/llvm-install/include -std=c++14 -fno-exceptions -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/halidenightly/build_bot/worker/llvm-11-x86-64-linux/llvm-project/llvm/../lld/include -DLLVM_VERSION=110  -DWITH_NVPTX  -DWITH_ARM  -DWITH_HEXAGON  -DWITH_AARCH64  -DWITH_X86  -DWITH_OPENCL  -DWITH_METAL  -DWITH_OPENGL  -DWITH_D3D12  -DWITH_MIPS  -DWITH_POWERPC  -DWITH_INTROSPECTION        -DWITH_WEBASSEMBLY -funwind-tables -c /home/halidenightly/build_bot/worker/x86-64-linux-testbranch-11-make/halide-source/src/Memoization.cpp -o bin/build/Memoization.o -MMD -MP -MF bin/build/Memoization.d -MT bin/build/Memoization.o
/home/halidenightly/build_bot/worker/x86-64-linux-testbranch-11-make/halide-source/src/InjectOpenGLIntrinsics.cpp: In member function ‘virtual Halide::Expr Halide::Internal::InjectOpenGLIntrinsics::visit(const Halide::Internal::Call*)’:
/home/halidenightly/build_bot/worker/x86-64-linux-testbranch-11-make/halide-source/src/InjectOpenGLIntrinsics.cpp:51:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
             for (size_t i = 0; i < std::min(dims, 2); i++) {
                                ~~^~~~~~~~~~~~~~~~~~~

This would have ideally been caught by our clang-tidy check.

@steven-johnson steven-johnson deleted the pr/5545_2 branch December 16, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steven-johnson @alexreinking @xndcn