Make IRComparer consider nans to be less than non-nans. #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
changed the title
|
Does this need any "is in strict fp mode" check? |
I don't believe so, no. I don't think we ever want to consider |
abadams
approved these changes
Feb 21, 2022
|
Sorry, I just realized I forgot to actually use the updated target in the test... going to fix that now. |
abadams
reviewed
Feb 21, 2022
abadams
reviewed
Feb 21, 2022
abadams
reviewed
Feb 21, 2022
|
Failing test looks like a performance flake to me... what are your thoughts, @abadams? |
|
Leaving this for someone else to merge or patch further. |
|
Thanks for fixing this issue! Would it be possible to make a 13.0.5 release with this fix? |
|
@apartridge - that would be possible, but my bandwidth is somewhat limited until mid-week next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our IRComparer's
compare_scalarbelieved that all floating point values are totally ordered, which is not true. NaNs always compare false in ordering comparisons.Fixes #6624