Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscheduler test reorg, part 1 #7064

Merged
merged 9 commits into from
Oct 6, 2022
Merged

Conversation

steven-johnson
Copy link
Contributor

@steven-johnson steven-johnson commented Oct 5, 2022

The end goal here is to move the tests for all autoschedulers into test/autoschedulers/<name>. This part handles the tests for the Mullapudi2016 autoscheduler:

  • Moves from test/auto_schedule
  • Silences a lot of the irrelevant noise that the tests emit to stdout (see also tests for Mullapudi2016 and Li2018 aren't very good #7063)
  • Ensure that the tests that run manual-and-auto tests actually check the times for plausibility (where "plausible" means "no worse than the current status quo")
  • Changes the test group label from auto_schedule to autoschedulers (note that auto_schedule is retained for now but will be eliminated once everything is migrated)

The end goal here is to move the tests for all autoschedulers into `test/autoschedulers/<name>`. This part handles the tests for the Mullapudi2016 autoscheduler:
- Moves from test/auto_schedule
- Silences a lot of the irrelevant noise that the tests emit to stdout (see also #7063)
- Ensure that the tests that run manual-and-auto tests actually check the times for plausibility (where "plausible" means "no worse than the current status quo")
- Changes the test group label from `auto_schedule` to `autoschedulers`
@steven-johnson steven-johnson marked this pull request as ready for review October 6, 2022 17:19
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just one oddity I want to address.

test/autoschedulers/CMakeLists.txt Outdated Show resolved Hide resolved
test/autoschedulers/mullapudi2016/reorder.cpp Show resolved Hide resolved
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-johnson steven-johnson merged commit 9de4906 into main Oct 6, 2022
@steven-johnson steven-johnson deleted the srj/autoscheduler-tests-1 branch October 6, 2022 18:09
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
* Autoscheduler test reorg, part 1

The end goal here is to move the tests for all autoschedulers into `test/autoschedulers/<name>`. This part handles the tests for the Mullapudi2016 autoscheduler:
- Moves from test/auto_schedule
- Silences a lot of the irrelevant noise that the tests emit to stdout (see also halide#7063)
- Ensure that the tests that run manual-and-auto tests actually check the times for plausibility (where "plausible" means "no worse than the current status quo")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants