Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscheduler test reorg, part 2 #7065

Merged
merged 20 commits into from
Oct 6, 2022
Merged

Conversation

steven-johnson
Copy link
Contributor

@steven-johnson steven-johnson commented Oct 5, 2022

Move the Li2018 tests to tests/autoschedulers. Drive-by fix to the Python test. Fixes #4053

The end goal here is to move the tests for all autoschedulers into `test/autoschedulers/<name>`. This part handles the tests for the Mullapudi2016 autoscheduler:
- Moves from test/auto_schedule
- Silences a lot of the irrelevant noise that the tests emit to stdout (see also #7063)
- Ensure that the tests that run manual-and-auto tests actually check the times for plausibility (where "plausible" means "no worse than the current status quo")
- Changes the test group label from `auto_schedule` to `autoschedulers`
Move the Li2018 tests to tests/autoschedulers. Drive-by fix to the Python test.
@steven-johnson steven-johnson changed the base branch from srj/autoscheduler-tests-1 to main October 5, 2022 01:38
@steven-johnson steven-johnson changed the base branch from main to srj/autoscheduler-tests-1 October 6, 2022 17:20
@steven-johnson steven-johnson marked this pull request as ready for review October 6, 2022 17:20
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a slam-dunk 👍

@alexreinking
Copy link
Member

alexreinking commented Oct 6, 2022

...but please add "Fixes" to the PR description for the relevant issues 🙂 (e.g. #4053)

Base automatically changed from srj/autoscheduler-tests-1 to main October 6, 2022 18:09
@steven-johnson steven-johnson merged commit 7086c6f into main Oct 6, 2022
@steven-johnson steven-johnson deleted the srj/autoscheduler-tests-2 branch October 6, 2022 18:11
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
* Autoscheduler test reorg, part 2

Move the Li2018 tests to tests/autoschedulers. Drive-by fix to the Python test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: reorganize the autoscheduler(s) in the codebase
2 participants