Improve support for Arm baremetal compilation and runtime #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Target feature "semihosting" mode for baremetal runtime - Fix error of aligned_alloc() when compiled by Arm GNU toolchain
This comment was marked as outdated.
This comment was marked as outdated.
steven-johnson
requested changes
Jan 17, 2023
This was referenced Jan 18, 2023
stevesuzuki-arm
commented
Jan 18, 2023
steven-johnson
approved these changes
Jan 18, 2023
alexreinking
requested changes
Jan 18, 2023
apps/HelloBaremetal/cmake-external_project/generator/CMakeLists.txt
Outdated
Show resolved
Hide resolved
apps/HelloBaremetal/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| !enable_neon.s | |||
There was a problem hiding this comment.
@steven-johnson - we should add some sort of linter / autoformatter to prevent line-ending churn
Comment on lines
+20
to
+21
| # Find Halide. Instead of the package Halide, HalideHelpers is enough as we don't use JIT mode. | ||
| find_package(HalideHelpers REQUIRED) |
There was a problem hiding this comment.
Future design note: As you've observed here and as I've described elsewhere, I think the final design I want to implement (not a blocker here) is to make find_package(Halide REQUIRED) do what find_package(HalideHelpers REQUIRED) does today and if users know they want JIT mode they can add that as a component as in find_package(Halide REQUIRED JIT).
alexreinking
requested changes
Jan 20, 2023
|
Where does this PR stand? |
For this and the others, I need to re-review. |
|
Checking in again, is this just in need of a re-review? |
alexreinking
approved these changes
Feb 7, 2023
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Improve support for Arm baremetal compilation and runtime - Add Target feature "semihosting" mode for baremetal runtime - Fix error of aligned_alloc() when compiled by Arm GNU toolchain * Modify comments for Target feature semihosting * Add an example app to guide cross-compilation for baremetal target * Update build steps in HelloBaremetal * Fix line-ending * Set CMake variable BAREMETAL in toolchain file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HelloBaremetalto guide how to cross-compile for baremetal target with CMake