Add a warning if a Generator declares any Outputs before the final Input (Fixes #7669) #7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
reviewed
Jul 21, 2023
| internal_assert(param->generator == nullptr || param->generator == generator); | ||
| param->generator = generator; | ||
| filter_generator_params.push_back(param); | ||
| const char *const io_order_warning = "Generators will always produce code that orders all Inputs before all Outputs; " |
There was a problem hiding this comment.
The warning should probably include instructions to override that method if you explicitly want to have outputs declared before inputs
There was a problem hiding this comment.
Not sure if I entirely agree with this -- part of me wants to push back and say that anyone who really needs it will figure it out. But I'm probably overthinking it...
abadams
approved these changes
Jul 24, 2023
steven-johnson
added
the
release_notes
steven-johnson
added a commit
that referenced
this pull request
Jul 24, 2023
Accidentally checked in #7697 with the failure mode as error, not warning
steven-johnson
added a commit
that referenced
this pull request
Jul 24, 2023
Accidentally checked in #7697 with the failure mode as error, not warning
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…put (Fixes halide#7669) (halide#7697) * Add a warning if a Generator declares any Outputs before the final Input (Fixes halide#7669) See halide#7669 for details * Update abstractgeneratortest_generator.cpp * Add note about allow_out_of_order_inputs_and_outputs() to warning
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
Accidentally checked in halide#7697 with the failure mode as error, not warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7669 for details
attn @Copper280z