Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning for unsupported compilers #8362

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

alexreinking
Copy link
Member

We haven't supported building with Clang 12 or below in a long time. No need to keep this in our build.

@alexreinking alexreinking marked this pull request as ready for review July 31, 2024 14:33
@alexreinking
Copy link
Member Author

Fuzz failure unrelated:

Original: (int64(int32(uint16((uint8)buf_u8(x))))*int64(((((uint8)106 - (uint8)127) + (uint8)11)*uint8((uint16)rounding_shift_right(uint16((uint8)buf_u8(x)), (uint16)11)))))
Lossless cast: (uint16((uint8)buf_u8(x))*uint16(((((uint8)106 - (uint8)127) + (uint8)11)*uint8((uint16)rounding_shift_right(uint16((uint8)buf_u8(x)), (uint16)11)))))

@steven-johnson
Copy link
Contributor

Fuzz failure unrelated:

Original: (int64(int32(uint16((uint8)buf_u8(x))))*int64(((((uint8)106 - (uint8)127) + (uint8)11)*uint8((uint16)rounding_shift_right(uint16((uint8)buf_u8(x)), (uint16)11)))))
Lossless cast: (uint16((uint8)buf_u8(x))*uint16(((((uint8)106 - (uint8)127) + (uint8)11)*uint8((uint16)rounding_shift_right(uint16((uint8)buf_u8(x)), (uint16)11)))))

Opened as #8364

@alexreinking
Copy link
Member Author

Not sure about the Metal hanging failure, but clearly unrelated as the warning wasn't being passed to the compiler in the first place.

@alexreinking alexreinking merged commit 77e5dd1 into main Aug 1, 2024
15 of 16 checks passed
@alexreinking alexreinking deleted the build/drop-warning branch August 1, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants