Two more build fixes #8371
Merged
Two more build fixes #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not known by GCC13: https://ci.debian.net/packages/h/halide/testing/i386/50047733/ and fails with ``` /usr/bin/g++ -DHALIDE_ENABLE_RTTI -DHALIDE_VERSION_MAJOR=18 -DHALIDE_VERSION_MINOR=0 -DHALIDE_VERSION_PATCH=0 -DHALIDE_WITH_EXCEPTIONS -isystem /usr/include/halide18 -O3 -DNDEBUG -MD -MT CMakeFiles/main.dir/main.cpp.o -MF CMakeFiles/main.dir/main.cpp.o.d -o CMakeFiles/main.dir/main.cpp.o -c /tmp/autopkgtest.pviDWM/build.Sjp/src/test/integration/jit/main.cpp In file included from /tmp/autopkgtest.pviDWM/build.Sjp/src/test/integration/jit/main.cpp:1: /usr/include/halide18/Halide.h: In member function ‘Halide::float16_t::operator _Float16() const’: /usr/include/halide18/Halide.h:3054:40: error: SSE register return with SSE2 disabled 3054 | explicit operator _Float16() const { | ^ /usr/include/halide18/Halide.h:3057:16: error: SSE register return with SSE2 disabled 3057 | return result; | ^~~~~~ /usr/include/halide18/Halide.h: In constructor ‘Halide::Expr::Expr(_Float16)’: /usr/include/halide18/Halide.h:4679:64: error: invalid conversion from type ‘_Float16’ without option ‘-msse2’ 4679 | : IRHandle(Internal::FloatImm::make(Float(16), (double)x)) { | ^ ninja: build stopped: subcommand failed. ``` with GCC14.
|
CMake honors the CXX environment variable. Is that getting unset somehow? |
|
It's not getting pass-through either: |
alexreinking
added
the
buildbot_test_everything
Strange, but thanks for trying. I'll approve this. |
alexreinking
approved these changes
Aug 7, 2024
|
As usual, osx is being oh so picky. |
|
That particular failure is fixed by #8381 |
|
@alexreinking @steven-johnson thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
CXXpropagation, there isn't really any way to test with any but default compiler.In fact, that happened to be GCC, and on i386 the test didn't pass, even though the package built,
because it was built with clang. The second patch addresses the GCC failure on i386,
but there are more issues on other architectures i strongly suspect.