Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FetchContent with a custom dependency provider #8378

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

alexreinking
Copy link
Member

This is the first big change from #8360

The build no longer uses FetchContent, instead using find_package always and everywhere. When Halide is the top-level project, it will (by default) inject a dependency provider that overrides the wabt, flatbuffers, and pybind11 packages with FetchContent. Users can opt-out by setting Halide_USE_FETCHCONTENT=NO.

This also bumps the required wabt version to the latest release (1.0.36). This version includes a patch I submitted that fixes the CMake package when wabt is built with OpenSSL rather than picosha2.


Here are relevant links to the docs:

@alexreinking alexreinking added the release_notes For changes that may warrant a note in README for official releases. label Aug 8, 2024
@alexreinking
Copy link
Member Author

Spurious failure in performance_inner_loop_parallel on different targets, both on linux-worker-1.

@alexreinking alexreinking merged commit 56f14c8 into main Aug 9, 2024
14 of 16 checks passed
@alexreinking alexreinking deleted the build/refactor-fetchcontent branch August 9, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_notes For changes that may warrant a note in README for official releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants