Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows tray example #139

Merged
merged 10 commits into from
Jan 19, 2021
Merged

Add windows tray example #139

merged 10 commits into from
Jan 19, 2021

Conversation

ilopX
Copy link
Contributor

@ilopX ilopX commented Jan 13, 2021

Add windows tray example

image

New Win32api functions:

  • Shell_NotifyIcon
  • GetSubMenu
  • DestroyMenu
  • TrackPopupMenuEx

New Struct:

  • NOTIFYICONDATA
  • TPMPARAMS

New constant:

  • Shell_NotifyIcon uFlags
  • Shell_NotifyIcon WndProc callback msg
  • NOTIFYICONDATA::uFlags
  • NOTIFYICONDATA::dwState
  • NOTIFYICONDATA::dwInfoFlags
  • TrackPopupMenuEx: uFlag
  • LoadImage: type, fuLoad

@timsneath
Copy link
Contributor

Oooh -- this is cool! Thank you. I'll take a look over it. We're just doing some nasty breaking changes in FFI right now, so that's occupying my attention, but this is perfect!

@ilopX
Add window tray example
7bb739a 
new Win32pai:
* Shell_NotifyIcon
* GetSubMenu
* DestroyMenu
* TrackPopupMenuEx

new struct:
* NOTIFYICONDATA
* TPMPARAMS

new constants:
* Shell_NotifyIcon uFlags
* Shell_NotifyIcon WndProc callback msg
* NOTIFYICONDATA::uFlags
* NOTIFYICONDATA::dwState
* NOTIFYICONDATA::dwInfoFlags
* TrackPopupMenuEx uFlag
* LoadImage type, fuLoad
@ilopX ilopX force-pushed the shell_notify_icon_example branch from 3c35daa to 7bb739a Compare January 16, 2021 01:48
timsneath
timsneath suggested changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@timsneath timsneath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice work -- congrats @ilopX. This is not easy to get right, as I've learned through many hours of trial and error.

If we can resolve the string item for consistency, I'd be delighted to merge this. Note that I'm using the no-addressof branch as the development branch while I wait for .224 to land in in the dev branch (so CI is clean). So, unless that has merged at the time when you resubmit, it would be great if you can target this at that branch and I'll merge there and then land it all into master at the same time. Does that work?

lib/src/structs.dart Outdated Show resolved Hide resolved
lib/src/structs.dart Show resolved Hide resolved
@ilopX ilopX changed the base branch from master to no-addressof January 19, 2021 12:35
@ilopX ilopX requested a review from timsneath January 19, 2021 12:42
timsneath
timsneath approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@timsneath timsneath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! It's really encouraging to see others contribute high-quality code to this repo. I greatly appreciate you taking the time not only to submit a pull request, but to follow along with the changes for FFI and API metadata!

@timsneath timsneath merged commit 3746f90 into halildurmus:no-addressof Jan 19, 2021
@ilopX
Copy link
Contributor Author

ilopX commented Jan 19, 2021

Thank you. I'm honored that you accepted my pull request. It inspires me a lot.

@ilopX ilopX deleted the shell_notify_icon_example branch January 19, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsneath timsneath timsneath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilopX @timsneath