-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra shell file operation APIs #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Might be related to #463. I've been trying to reproduce this, with no luck so far :(. |
Thanks! Although, I'm not certain this is the same thing, btw, @halildurmus. This was a segfault, where Dart just quits without warning, rather than a process exit as in #463. The last displayed test attempt was It might be worth setting a larger number of test runs on this test suite and seeing if we can flush this out. |
I came across this today. You should be able to reproduce this with the following cmd script: @echo off
rem Run the dart test command 30 times
for /l %%i in (1,1,30) DO (
echo Run: %%i
call dart test test/winrt_calendar_test.dart test/winrt_collections_test.dart test/winrt_ireference_test.dart
) (You may need to run this script several times 😄) While running this script, you should see either a segfault or an error like this in some random test:
I think this is caused by calls to the I have looked at the other WinRT projections to see if they call Here is the relevant snippet from And this is from Basically, if the call to I think we should do the same, Created #642 for this. Curious to hear your thoughts. Note that I forgot to mention in #623, before we make NativeFinalizer call IUnknown's |
Also adds
example\recycle_bin.dart
, which demonstrates its usage.While running tests (prior to adding this new code), I got a random test abort, which can be an indication of a use-after-free failure. I've therefore changed
generate.cmd
to pass extra flags to a) run tests single-threaded, and b) randomize test ordering, in the hope that this will occur again. If so, the last test that run should deterministically be the failing test.Closes #629.