Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: use tanstack query to refactor post-related fetching #879

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 23, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

使用 TanStack Query 重构文章相关数据请求的相关逻辑。

Which issue(s) this PR fixes:

Ref halo-dev/halo#3360

Special notes for your reviewer:

测试方式:

  1. 测试文章相关联的页面,包括文章管理、分类、标签。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang February 23, 2023 02:59
@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 11:11AM (UTC)

@LIlGG
Copy link
Member

LIlGG commented Feb 23, 2023

/lgtm

文章相关界面均能正常请求。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确认一下文章详情页
image

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 23, 2023

New changes are detected. LGTM label has been removed.

@ruibaby
Copy link
Member Author

ruibaby commented Feb 23, 2023

确认一下文章详情页

Fixed

@guqing
Copy link
Member

guqing commented Feb 23, 2023

批量删除没有效果

@guqing
Copy link
Member

guqing commented Feb 23, 2023

批量删除没有效果

与此 PR 无关,新提交了 issue#3375

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 66a626c into halo-dev:main Feb 24, 2023
@ruibaby ruibaby deleted the refactor/post-related-query branch February 24, 2023 04:10
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 24, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…dev/console#879)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

使用 [TanStack Query](https://github.com/TanStack/query) 重构文章相关数据请求的相关逻辑。

#### Which issue(s) this PR fixes:

Ref halo-dev#3360

#### Special notes for your reviewer:

测试方式:

1. 测试文章相关联的页面,包括文章管理、分类、标签。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants