Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the original name when uploading the attachment to upyun oss #2185

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

braverayy
Copy link

@braverayy braverayy commented Jun 23, 2022

What type of PR is this?

/kind improvement
/area core

What this PR does / why we need it:

problem:
附件存储类型选择又拍云时,上传到又拍云的文件名被重命名为原图片名的MD5值。

resolve:
参考 #1500,通过 FilePathDescriptor 来构建 fullPath,relativePath 等

Which issue(s) this PR fixes:

Fixes #2181

Does this PR introduce a user-facing change?

重构又拍云附件上传文件命名规则为保持原文件名

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby June 23, 2022 09:14
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

经测试功能正常
/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@guqing
Copy link
Member

guqing commented Jun 23, 2022

hi @okayhu, 由于是第一次贡献,你需要签署一下开源协议
#2185 (comment)
点击这条评论中的 badge 即可签署

@guqing
Copy link
Member

guqing commented Jun 23, 2022

/milestone 1.5.x

@f2c-ci-robot f2c-ci-robot bot added this to the 1.5.x milestone Jun 23, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/milestone 1.5.x

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@guqing
Copy link
Member

guqing commented Jun 23, 2022

/cherry-pick release-1.5

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #2186

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing
Copy link
Member

guqing commented Jun 23, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

又拍云图片上传未使用原图片名称
5 participants