Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add cache control for reverse proxy resources #5392

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 22, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

为插件静态代理资源增加缓存控制以减少不必要的请求

Which issue(s) this PR fixes:

Fixes #5357

Does this PR introduce a user-facing change?

为插件静态代理资源增加缓存控制以减少不必要的请求

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 56.87%. Comparing base (5fdf6c0) to head (f16de44).
Report is 21 commits behind head on main.

Files Patch % Lines
...n/resources/ReverseProxyRouterFunctionFactory.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5392      +/-   ##
============================================
- Coverage     56.91%   56.87%   -0.05%     
+ Complexity     3319     3315       -4     
============================================
  Files           587      587              
  Lines         18968    18964       -4     
  Branches       1401     1400       -1     
============================================
- Hits          10795    10785      -10     
- Misses         7594     7599       +5     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LIlGG, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bf6bf8c into halo-dev:main Feb 23, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 25, 2024
@guqing guqing deleted the refactor/5357 branch February 26, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

几乎所有插件的静态资源都没有进入浏览器缓存
3 participants