-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.12] Fix the problem of being unable to login when 2FA was enabled but TOTP was not configured #5401
[release-2.12] Fix the problem of being unable to login when 2FA was enabled but TOTP was not configured #5401
Conversation
Signed-off-by: John Niang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.12 #5401 +/- ##
==================================================
+ Coverage 56.91% 56.93% +0.02%
- Complexity 3319 3326 +7
==================================================
Files 587 587
Lines 18968 18968
Branches 1401 1401
==================================================
+ Hits 10795 10799 +4
+ Misses 7594 7590 -4
Partials 579 579 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #5400
/assign JohnNiang