Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.12] Fix the problem of being unable to login when 2FA was enabled but TOTP was not configured #5401

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #5400

/assign JohnNiang

修复开启两步验证但未配置 TOTP 可能无法登录的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 25, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2024
@ruibaby ruibaby added this to the 2.12.4 milestone Feb 25, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.93%. Comparing base (8af623f) to head (94fa83d).
Report is 1 commits behind head on release-2.12.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-2.12    #5401      +/-   ##
==================================================
+ Coverage           56.91%   56.93%   +0.02%     
- Complexity           3319     3326       +7     
==================================================
  Files                 587      587              
  Lines               18968    18968              
  Branches             1401     1401              
==================================================
+ Hits                10795    10799       +4     
+ Misses               7594     7590       -4     
  Partials              579      579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Feb 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5200d86 into halo-dev:release-2.12 Feb 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants