-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pref: refactor default editor audio block upload logic #5421
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5421 +/- ##
============================================
- Coverage 56.91% 56.81% -0.10%
- Complexity 3319 3321 +2
============================================
Files 587 589 +2
Lines 18968 19082 +114
Branches 1401 1365 -36
============================================
+ Hits 10795 10841 +46
- Misses 7594 7668 +74
+ Partials 579 573 -6 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area ui
/area editor
What this PR does / why we need it:
重构默认编辑器音频组件。使其支持上传、取消上传、从附件库选择、替换等功能。
How to test it?
直接拖动、复制或选择文件上传一个音频,查看是否显示上传进度条,取消、重试功能是否正常
Which issue(s) this PR fixes:
Fixes #5239
Does this PR introduce a user-facing change?