-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pref: optimize the help style of some formkit components #5521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5521 +/- ##
============================================
- Coverage 56.91% 56.56% -0.35%
+ Complexity 3319 3310 -9
============================================
Files 587 592 +5
Lines 18968 19178 +210
Branches 1401 1355 -46
============================================
+ Hits 10795 10848 +53
- Misses 7594 7769 +175
+ Partials 579 561 -18 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
经过测试,radio 组件正常。已补充 checkbox 的样式。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area ui
What this PR does / why we need it:
优化 formkit 中 checkout、repeater、group 组件的 help 样式。
移除 checkout 的内边距
为 repeater、group 组件增加底部边距
How to test it?
观察上述组件的 help 样式是否正常。
Which issue(s) this PR fixes:
Fixes #5411
Does this PR introduce a user-facing change?