Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize query for category association posts count to prevent blocking due to large data #5658

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 7, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.15.x

What this PR does / why we need it:

优化分类关联文章数量的查询避免因查询数据量过大而导致的阻塞或内存溢出

Does this PR introduce a user-facing change?

优化分类关联文章数量的查询避免因查询数据量过大而导致的阻塞或内存溢出

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 7, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 7, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and minliacom April 7, 2024 05:51
@guqing guqing force-pushed the refactor/post-query-in-category-reconciler branch from 6344610 to 283bfdb Compare April 7, 2024 06:48
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.57%. Comparing base (5fdf6c0) to head (283bfdb).
Report is 96 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5658      +/-   ##
============================================
- Coverage     56.91%   56.57%   -0.35%     
- Complexity     3319     3324       +5     
============================================
  Files           587      595       +8     
  Lines         18968    19229     +261     
  Branches       1401     1353      -48     
============================================
+ Hits          10795    10878      +83     
- Misses         7594     7793     +199     
+ Partials        579      558      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 52204d6 into halo-dev:main Apr 8, 2024
8 checks passed
@guqing guqing deleted the refactor/post-query-in-category-reconciler branch April 8, 2024 09:18
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants