Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: limit the datetime year of the post or page to four digits #5666

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Apr 8, 2024

What type of PR is this?

/kind improvement
/area ui

What this PR does / why we need it:

限定文章或页面中的发布日期中的年份为四位数,方便用户输入四位年份之后自定跳转至月份。

How to test it?

测试在 chrome 上输入四位年份之后,是否会自动跳转至月份。

Which issue(s) this PR fixes:

Fixes #5630

Does this PR introduce a user-facing change?

限定文章或页面中的发布日期中的年份为四位数

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Apr 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and ruibaby April 8, 2024 04:26
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@ruibaby ruibaby added this to the 2.15.x milestone Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.48%. Comparing base (5fdf6c0) to head (3b9cff5).
Report is 107 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5666      +/-   ##
============================================
- Coverage     56.91%   56.48%   -0.43%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19250     +282     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7814     +220     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 37f530b into halo-dev:main Apr 12, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4.0文章设置发布时间年份为何还是要输入6位才能自动切换到月份?
2 participants